eyhc
/
rendercv
mirror of https://github.com/eyhc1/rendercv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix design validator bug

This commit is contained in:
Sina Atalay 2024-02-18 15:12:24 +01:00
parent bb319b0427
commit e935764c40
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
rendercv/data_models.py
View File

@ -967,8 +967,18 @@ class RenderCVDataModel(RenderCVBaseModel):
) -> RenderCVDesign | Any: ) -> RenderCVDesign | Any:
"""Initialize the custom theme if it is used and validate it. Otherwise, return """Initialize the custom theme if it is used and validate it. Otherwise, return
the built-in theme.""" the built-in theme."""
if design["theme"] in available_themes: # type: ignore # `get_args` for an Annotated object returns the arguments when Annotated is
# it is a built-in theme, validate and return it: # used. The first argument is actually the union of the types, so we need to
# access the first argument to use isinstance function.
theme_data_model_types = get_args(RenderCVDesign)[0]
if isinstance(design, theme_data_model_types):
# then it means RenderCVDataModel is already initialized with a design, so
# return it as is:
return design
elif design["theme"] in available_themes: # type: ignore
# then it means it's a built-in theme, but it is not initialized (validated)
# yet. So, validate and return it:
return rendercv_design_validator.validate_python(design) return rendercv_design_validator.validate_python(design)
else: else:
theme_name: str = design["theme"] # type: ignore theme_name: str = design["theme"] # type: ignore
@ -1101,13 +1111,7 @@ def get_a_sample_data_model(name: str = "John Doe") -> RenderCVDataModel:
RenderCVDataModel: A sample data model. RenderCVDataModel: A sample data model.
""" """
sections = { sections = {
"summary": [ "summary_or_something_else": [""],
(
"I am a mechanical engineer with a [passion](https://example.com) for"
" software development."
),
"I am a **quick learner** and ***I love*** to learn new things.",
],
"education": [ "education": [
EducationEntry( EducationEntry(
institution="Your University", institution="Your University",