From 79c2ac1ba6fd69a178d6e2afd6693b50e95b8e53 Mon Sep 17 00:00:00 2001
From: Sina Atalay <sinatalay@hotmail.com>
Date: Fri, 17 May 2024 15:59:12 +0300
Subject: [PATCH] sb2nov: fix margin problems

---
 rendercv/themes/sb2nov/BulletEntry.j2.tex     |  2 +-
 rendercv/themes/sb2nov/Preamble.j2.tex        | 28 +------------------
 .../themes/sb2nov/PublicationEntry.j2.tex     |  1 -
 rendercv/themes/sb2nov/__init__.py            | 27 ------------------
 4 files changed, 2 insertions(+), 56 deletions(-)

diff --git a/rendercv/themes/sb2nov/BulletEntry.j2.tex b/rendercv/themes/sb2nov/BulletEntry.j2.tex
index 17a13c1..0bb8929 100644
--- a/rendercv/themes/sb2nov/BulletEntry.j2.tex
+++ b/rendercv/themes/sb2nov/BulletEntry.j2.tex
@@ -3,5 +3,5 @@
 ((* endif *))
 
 \begin{onecolentry}
-    \textbullet \hspace{<<design.margins.entry_area.bullet_width>>-0.2cm}<<entry.bullet>>
+    $\circ$ <<entry.bullet>>
 \end{onecolentry}
diff --git a/rendercv/themes/sb2nov/Preamble.j2.tex b/rendercv/themes/sb2nov/Preamble.j2.tex
index b02f72d..62ea8b9 100644
--- a/rendercv/themes/sb2nov/Preamble.j2.tex
+++ b/rendercv/themes/sb2nov/Preamble.j2.tex
@@ -105,7 +105,7 @@
         parsep=<<design.margins.highlights_area.vertical_between_bullet_points>>,
         partopsep=0pt,
         itemsep=0pt,
-        leftmargin=<<design.margins.highlights_area.left>> + 10pt + <<design.margins.entry_area.bullet_width>>
+        leftmargin=<<design.margins.highlights_area.left>> + 10pt
     ]
 }{
     \end{itemize}
@@ -122,20 +122,6 @@
     \end{adjustwidth}
 } % new environment for one column entries
 
-\newenvironment{onecolentrybulleted}{
-    \onecolentry
-    \setcolumnwidth{<<design.margins.entry_area.bullet_width>>, \fill}
-    \begin{paracol}{2}
-    \vspace*{\fill}
-    \textbullet
-    \vspace*{3px}
-    \vspace*{\fill}
-    \switchcolumn
-}{
-    \end{paracol}
-    \endonecolentry
-} % new environment for one column entries with bullets
-
 \newenvironment{twocolentry}[2][]{
     \onecolentry
     \def\secondColumn{#2}
@@ -147,18 +133,6 @@
     \endonecolentry
 } % new environment for two column entries
 
-\newenvironment{threecolentry}[3][]{
-    \onecolentry
-    \def\thirdColumn{#3}
-    \setcolumnwidth{<<design.margins.entry_area.bullet_width>>, \fill, <<design.margins.entry_area.date_and_location_width>>}
-    \begin{paracol}{3}
-    #2 \switchcolumn
-}{
-    \switchcolumn \raggedleft \thirdColumn
-    \end{paracol}
-    \endonecolentry
-} % new environment for three column entries
-
 \newenvironment{header}{
     \setlength{\topsep}{0pt}\par\kern\topsep\centering\linespread{1.5}
 }{
diff --git a/rendercv/themes/sb2nov/PublicationEntry.j2.tex b/rendercv/themes/sb2nov/PublicationEntry.j2.tex
index 7018198..12ade91 100644
--- a/rendercv/themes/sb2nov/PublicationEntry.j2.tex
+++ b/rendercv/themes/sb2nov/PublicationEntry.j2.tex
@@ -22,7 +22,6 @@
     \vspace{<<design.margins.highlights_area.vertical_between_bullet_points>>-3px}
 
     \begin{onecolentry}
-    \hspace{<<design.margins.entry_area.bullet_width>>}%
     ((* endif *))
         ((* if entry.doi -*))
         \href{<<entry.doi_url>>}{<<entry.doi>>}
diff --git a/rendercv/themes/sb2nov/__init__.py b/rendercv/themes/sb2nov/__init__.py
index 6be073f..d7c4175 100644
--- a/rendercv/themes/sb2nov/__init__.py
+++ b/rendercv/themes/sb2nov/__init__.py
@@ -5,28 +5,6 @@ import pydantic
 from .. import ThemeOptions, LaTeXDimension, Margins, EntryAreaMargins
 
 
-class EntryAreaMarginsForSb2nov(EntryAreaMargins):
-    """This class is a data model for the entry area margins."""
-
-    bullet_width: LaTeXDimension = pydantic.Field(
-        default="0.6 cm",
-        title="Width of the Entry Bullet",
-        description=(
-            "The width of the bullet for each entry. The default value is 0.6 cm."
-        ),
-    )
-
-
-class MarginsForSb2nov(Margins):
-    """This class is a data model for the margins."""
-
-    entry_area: EntryAreaMarginsForSb2nov = pydantic.Field(
-        default=EntryAreaMarginsForSb2nov(),
-        title="Entry Area Margins",
-        description="Entry area margins.",
-    )
-
-
 class Sb2novThemeOptions(ThemeOptions):
     """This class is the data model of the theme options for the `sb2nov` theme."""
 
@@ -53,8 +31,3 @@ class Sb2novThemeOptions(ThemeOptions):
             " 24 pt."
         ),
     )
-    margins: MarginsForSb2nov = pydantic.Field(
-        default=MarginsForSb2nov(),
-        title="Margins",
-        description="Page, section title, entry field, and highlights field margins.",
-    )