From 5a5b6e687fe424772b0724f90a3f28fdd567bd76 Mon Sep 17 00:00:00 2001
From: Sina Atalay <sinatalay@hotmail.com>
Date: Sat, 9 Sep 2023 19:02:20 +0200
Subject: [PATCH] add Skills section

---
 rendercv/templates/classic/classic.tex.j2     | 36 +++++++++++++++++--
 .../classic/components/normal_entry.tex.j2    | 10 ++++--
 .../classic/components/one_line_entry.tex.j2  | 12 +++++++
 .../components/one_line_information.tex.j2    |  7 ----
 4 files changed, 52 insertions(+), 13 deletions(-)
 create mode 100644 rendercv/templates/classic/components/one_line_entry.tex.j2
 delete mode 100644 rendercv/templates/classic/components/one_line_information.tex.j2

diff --git a/rendercv/templates/classic/classic.tex.j2 b/rendercv/templates/classic/classic.tex.j2
index 8c0a714..3f06b22 100644
--- a/rendercv/templates/classic/classic.tex.j2
+++ b/rendercv/templates/classic/classic.tex.j2
@@ -2,6 +2,7 @@
 ((* from "components/education_entry.tex.j2" import education_entry with context *))
 ((* from "components/experience_entry.tex.j2" import experience_entry with context *))
 ((* from "components/normal_entry.tex.j2" import normal_entry with context *))
+((* from "components/one_line_entry.tex.j2" import one_line_entry with context *))
 ((* from "components/header.tex.j2" import header with context *))
 
 \documentclass[10pt, a4paper]{memoir}
@@ -134,8 +135,7 @@
         name=academic_project.name,
         highlights=academic_project.highlight_strings,
         date_and_location_strings=academic_project.date_and_location_strings,
-        url=academic_project.url
-        urlText=""
+        url=academic_project.markdown_url,
     )|indent(4)>>
     ((* if not loop.last *))
     \vspace*{<<design.vertical_margin_between_entries>>}
@@ -148,7 +148,37 @@
     <<normal_entry(
         name=certificate.name,
         highlights=certificate.highlight_strings,
-        date_and_location_strings=certificate.date_and_location_strings
+        date_and_location_strings=certificate.date_and_location_strings,
+        url = certificate.url,
+        text_url = "Course certificate"
+    )|indent(4)>>
+    ((* if not loop.last *))
+    \vspace*{<<design.vertical_margin_between_entries>>}
+
+    ((* endif *))
+((* endfor *))
+
+    \section{Skills}
+((* for skill in cv.skills *))
+    <<one_line_entry(
+        name=skill.name,
+        details=skill.details,
+        url = skill.url,
+        text_url = skill.url
+    )|indent(4)>>
+    ((* if not loop.last *))
+    \vspace*{<<design.vertical_margin_between_entries>>}
+
+    ((* endif *))
+((* endfor *))
+
+    \section{Skills}
+((* for skill in cv.skills *))
+    <<one_line_entry(
+        name=skill.name,
+        details=skill.details,
+        url = skill.url,
+        text_url = skill.url
     )|indent(4)>>
     ((* if not loop.last *))
     \vspace*{<<design.vertical_margin_between_entries>>}
diff --git a/rendercv/templates/classic/components/normal_entry.tex.j2 b/rendercv/templates/classic/components/normal_entry.tex.j2
index d64eade..107a358 100644
--- a/rendercv/templates/classic/components/normal_entry.tex.j2
+++ b/rendercv/templates/classic/components/normal_entry.tex.j2
@@ -1,7 +1,7 @@
 ((* from "components/highlights.tex.j2" import highlights as print_higlights with context *))
 ((* from "components/date_and_location_strings.tex.j2" import date_and_location_strings as print_date_and_locations *))
 
-((* macro normal_entry(name, highlights, date_and_location_strings, url, urlText)*))
+((* macro normal_entry(name, highlights, date_and_location_strings, url, text_url=none)*))
 ((# \begin{tabularx}{⟨width⟩}[⟨pos⟩]{⟨preamble⟩} #))
     ((# width: \textwidth #))
     ((# preamble: first column, second column #))
@@ -9,8 +9,12 @@
         ((# second column: R{<<design.date_and_location_width>>}; constant width ragged right column #))
 \begin{tabularx}{\textwidth}{X R{<<design.date_and_location_width>>}}
     ((* if url is not none *))
-        ((* set markdownUrl = "["+urlText+"]("+ str(url) +")" *))
-    \textbf{<<name>>}, <<markdownUrl|markdown_to_latex>>
+        ((* if text_url is not none *))
+        ((* set markdown_url = "["+text_url+"]("+ str(url) +")" *))
+    \textbf{<<name>>}, <<markdown_url|markdown_to_latex>>
+        ((* elif url|is_markdown *))
+    \textbf{<<name>>}, <<url|markdown_to_latex>>
+        ((* endif *))
     ((* else *))
     \textbf{<<name>>}
     ((* endif *))
diff --git a/rendercv/templates/classic/components/one_line_entry.tex.j2 b/rendercv/templates/classic/components/one_line_entry.tex.j2
new file mode 100644
index 0000000..940dca1
--- /dev/null
+++ b/rendercv/templates/classic/components/one_line_entry.tex.j2
@@ -0,0 +1,12 @@
+((* macro one_line_entry(name, details, url, text_url=none)*))
+((# \begin{tabularx}{⟨width⟩}[⟨pos⟩]{⟨preamble⟩} #))
+    ((# width: \textwidth #))
+    ((# preamble: first column, second column #))
+        ((# first column:: X; variable width, ragged left column #))
+        ((# second column: R{<<design.date_and_location_width>>}; constant width ragged right column #))
+    \setlength{\leftskip}{0.2cm}
+    \textbf{<<name>>:} <<details>>
+
+    \vspace{\YMarginBetweenEntries}
+    \setlength{\leftskip}{0cm}
+((* endmacro *))
\ No newline at end of file
diff --git a/rendercv/templates/classic/components/one_line_information.tex.j2 b/rendercv/templates/classic/components/one_line_information.tex.j2
deleted file mode 100644
index 1637e6f..0000000
--- a/rendercv/templates/classic/components/one_line_information.tex.j2
+++ /dev/null
@@ -1,7 +0,0 @@
-((* macro one_line_information(name, details)*))
-\setlength{\leftskip}{0.2cm}
-\textbf{<<name>>:} <<details>>
-
-\vspace{<<design.vertical_margin_between_entries>>}
-\setlength{\leftskip}{0cm}
-((* endmacro *))
\ No newline at end of file