From fe13abfc876484f7e53c84df192fc29518251cf3 Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Tue, 10 Oct 2023 20:13:23 +0200 Subject: [PATCH 1/9] upload coverage data to smokeshow --- .github/workflows/python-tests.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index 92997cb..b61e1b5 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -38,8 +38,10 @@ jobs: run: | pip install pytest pytest-cov pytest --cov-report html --cov="." tests/ - - name: Upload coverage data - uses: actions/upload-artifact@v3 - with: - name: htmlcov - path: ./htmlcov \ No newline at end of file + - name: Upload coverage data to smokeshow + run: smokeshow upload ./htmlcov + env: + SMOKESHOW_GITHUB_STATUS_DESCRIPTION: CLI Coverage {coverage-percentage} + SMOKESHOW_GITHUB_COVERAGE_THRESHOLD: 50 + SMOKESHOW_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + SMOKESHOW_GITHUB_PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }} From 8833d55f4718df76d62013aa4e5d6128fb63ac96 Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Tue, 10 Oct 2023 20:16:32 +0200 Subject: [PATCH 2/9] fix python-tests.yml --- .github/workflows/python-tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index b61e1b5..a68e0d3 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -39,7 +39,9 @@ jobs: pip install pytest pytest-cov pytest --cov-report html --cov="." tests/ - name: Upload coverage data to smokeshow - run: smokeshow upload ./htmlcov + run: | + pip install smokeshow + smokeshow upload ./htmlcov env: SMOKESHOW_GITHUB_STATUS_DESCRIPTION: CLI Coverage {coverage-percentage} SMOKESHOW_GITHUB_COVERAGE_THRESHOLD: 50 From a55f7b5ba5ed46a63c698c180cfcaee9df2f8432 Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Tue, 10 Oct 2023 20:22:55 +0200 Subject: [PATCH 3/9] Update README.md --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 2d68626..016d664 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,7 @@ -# RenderCV [![python tests](https://github.com/sinaatalay/rendercv/actions/workflows/python-tests.yml/badge.svg)](https://github.com/sinaatalay/rendercv/actions/workflows/python-tests.yml) +# RenderCV +[![deploy MkDocs](https://github.com/sinaatalay/rendercv/actions/workflows/deploy-mkdocs.yaml/badge.svg)](https://github.com/sinaatalay/rendercv/actions/workflows/deploy-mkdocs.yaml) +[![python tests](https://github.com/sinaatalay/rendercv/actions/workflows/python-tests.yml/badge.svg)](https://github.com/sinaatalay/rendercv/actions/workflows/python-tests.yml) +![coverage](https://coverage-badge.samuelcolvin.workers.dev/sinaatalay/rendercv.svg) + + A Python application that creates CVs in PDF, HTML, LaTeX, etc., from a JSON/YAML input file. From 657f45f86b18d09650cbfc0998e7c91809700795 Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Tue, 10 Oct 2023 20:44:29 +0200 Subject: [PATCH 4/9] add coverage link to README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 016d664..0818d93 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # RenderCV [![deploy MkDocs](https://github.com/sinaatalay/rendercv/actions/workflows/deploy-mkdocs.yaml/badge.svg)](https://github.com/sinaatalay/rendercv/actions/workflows/deploy-mkdocs.yaml) [![python tests](https://github.com/sinaatalay/rendercv/actions/workflows/python-tests.yml/badge.svg)](https://github.com/sinaatalay/rendercv/actions/workflows/python-tests.yml) -![coverage](https://coverage-badge.samuelcolvin.workers.dev/sinaatalay/rendercv.svg) +[![coverage](https://coverage-badge.samuelcolvin.workers.dev/sinaatalay/rendercv.svg)](https://smokeshow.helpmanual.io/06110o3l5x474d540n3x/) A Python application that creates CVs in PDF, HTML, LaTeX, etc., from a JSON/YAML input file. From a16cea0aae3df17969a597ee20fd54e94c35a98c Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Tue, 10 Oct 2023 20:50:21 +0200 Subject: [PATCH 5/9] try to fix coverage badge --- .github/workflows/python-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index a68e0d3..0bbf306 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -43,7 +43,7 @@ jobs: pip install smokeshow smokeshow upload ./htmlcov env: - SMOKESHOW_GITHUB_STATUS_DESCRIPTION: CLI Coverage {coverage-percentage} + SMOKESHOW_GITHUB_STATUS_DESCRIPTION: Coverage {coverage-percentage} SMOKESHOW_GITHUB_COVERAGE_THRESHOLD: 50 SMOKESHOW_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SMOKESHOW_GITHUB_PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }} From fefeab580e751467cc191e1b96971393bc127902 Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Wed, 11 Oct 2023 17:00:03 +0200 Subject: [PATCH 6/9] update python-tests.yml --- .github/workflows/python-tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index 0bbf306..6d9b843 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -11,12 +11,13 @@ on: jobs: build: - runs-on: ubuntu-latest strategy: fail-fast: false matrix: + os: [ubuntu-latest, macos-latest, windows-latest] python-version: ["3.10", "3.11", "3.12"] + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 - name: Set up Python ${{ matrix.python-version }} @@ -39,6 +40,7 @@ jobs: pip install pytest pytest-cov pytest --cov-report html --cov="." tests/ - name: Upload coverage data to smokeshow + if: ${{matrix.os == 'ubuntu-latest' && matrix.python-version == "3.12"}} # upload coverage once run: | pip install smokeshow smokeshow upload ./htmlcov From 46e19bfc91da805183c85edaa8c6087f46f8ea2a Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Wed, 11 Oct 2023 17:00:57 +0200 Subject: [PATCH 7/9] disable mac-os tests for now --- .github/workflows/python-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index 6d9b843..4d310ab 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, windows-latest] python-version: ["3.10", "3.11", "3.12"] runs-on: ${{ matrix.os }} From 1bdce2a249b48eb0481803586f48266cfa35719f Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Wed, 11 Oct 2023 17:03:14 +0200 Subject: [PATCH 8/9] fix python-tests.yml --- .github/workflows/python-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index 4d310ab..ffe8805 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -40,7 +40,7 @@ jobs: pip install pytest pytest-cov pytest --cov-report html --cov="." tests/ - name: Upload coverage data to smokeshow - if: ${{matrix.os == 'ubuntu-latest' && matrix.python-version == "3.12"}} # upload coverage once + if: ${{matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'}} # upload coverage once run: | pip install smokeshow smokeshow upload ./htmlcov From 67e7fc750bd3a8fa68bfa031223642533bc2e3c9 Mon Sep 17 00:00:00 2001 From: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Date: Wed, 11 Oct 2023 17:05:43 +0200 Subject: [PATCH 9/9] fix windows tests --- .github/workflows/python-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index ffe8805..f584cf8 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -28,7 +28,7 @@ jobs: run: | python -m pip install --upgrade pip python -m pip install flake8 pytest - if [ -f requirements.txt ]; then pip install -r requirements.txt; fi + pip install -r requirements.txt - name: Lint with flake8 run: | # stop the build if there are Python syntax errors or undefined names